More Unicode 16 linebreaking changes #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
approved these changes
May 3, 2024
|
Note: running the ICU rbbi/RBBITest/TestUnicodeFiles on the current unicodetools LineBreakTest.txt (patched to replace U+1B50 with U+1BC0 since ICU does not yet have its LB change UTC-177-C46) on my uax14-integration branch failed with So our conformance tests would have caught that blunder during ICU integration. With the LineBreakTest.txt from this branch (similarly patched) the ICU test now passes. Note that this all passes after removing the exemptions for ICU-21097, so this one can be closed soon (with the resolution that Andy had predicted four years ago). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had missed this one in #798 because we were missing a LineBreakTest.txt action item for it:
[179-C25] Consensus: In UAX #14, change rule LB21a from HL (HY | BA) × to HL (HY | BA) × [^HL] (do not break after the hyphen in Hebrew-hyphen-non-Hebrew) to match the rationale for adding LB21a given in L2/11-141R. For Unicode Version 16.0. See document L2/24-064 item 5.2.